feat(hardware): Store overpressure count on plungers #17839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17839 +/- ##
=======================================
Coverage 23.42% 23.42%
=======================================
Files 2891 2891
Lines 222711 222711
Branches 19018 19018
=======================================
Hits 52171 52171
Misses 170529 170529
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This corresponds with a firmware PR that enables the firmware to store lifetime overpressure errors in the eeprom and report them out separately from regular motion errors.
also does a little touch-up where the auto-gen can IDs had gotten out of sync, the missing one is here now since this is the source of truth.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment